Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add send DAI spec using Anvil state #30804

Merged
merged 4 commits into from
Mar 7, 2025
Merged

test: add send DAI spec using Anvil state #30804

merged 4 commits into from
Mar 7, 2025

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Mar 6, 2025 •
edited
Loading

Description

In this PR, I add a new spec for Sending DAI, leveraging Anvil state injection.
This is the base work for changing the Swap specs to use this approach instead of Tenderly. Another PR will follow up with a Swap spec using the same approach.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Check ci

Screenshots/Recordings

Spec flow:

send-dai.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona self-assigned this Mar 6, 2025
@seaona seaona added area-qa Relating to QA work (Quality Assurance) team-qa QA team labels Mar 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [6457c26]
Page Load Metrics (1606 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14571947161111153
domContentLoaded1437186715819646
load1463188416069144
domInteractive2498402210
backgroundConnect116126146
firstReactRender156631209
getState46214157
initialActions01000
loadScripts1045143611898742
setupStore758232010
uiStartup16482184182910852
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

chloeYue
chloeYue approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Big improvement !

racitores
racitores approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@racitores racitores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work!

@seaona seaona added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit a011959 Mar 7, 2025
101 checks passed
@seaona seaona deleted the anvil-state branch March 7, 2025 15:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@racitores racitores racitores approved these changes

@chloeYue chloeYue chloeYue approved these changes

Assignees

@seaona seaona

Labels
area-qa Relating to QA work (Quality Assurance) release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-qa QA team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seaona @metamaskbot @racitores @chloeYue